Merge Request Review: Issue List Label Filter
Challenge summary
Review a merge request that adds label filters to a Vue 3 issue list: read the three-file diff, write your comments, fix what blocks the merge in the workspace, then compare with a sample review.
What you'll practice
- Review a change against the issue it claims to close.
- Rank what you find by what blocks the merge and what can wait.
- Write comments a teammate can act on, each with its line and its fix.
- Fix what holds the merge, then check it in the workspace.
What Premium unlocks
Premium unlocks the runnable workspace, behavioral checks, implementation walkthrough, and edge-case discussion. It opens as a merge request review: comment on the change in writing, fix it against the clock, then compare with a sample review.
A comment from the sample review
Must fix, on the new spec file: The assertion sits in a setTimeout that fires after the test has returned, so Jest reports a pass even if no issue renders. Make the test async, use fake timers or mock the request, await flushPromises() and then assert on what renders.
The sample review has ten comments like this one, ranked by what blocks the merge, each on its file and line.
Free related practice
Public interview reports: Taro (March 2024), Taro (February 2024) · GitLab frontend interview questions
Upgrade to FrontendAtlas Premium to unlock this challenge. Already upgraded? Sign in to continue.
Premium is $24 a month or $99 a year, less in many countries.